Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: temp fix to exclude build.bat before switching over to actions #239

Merged
merged 2 commits into from May 4, 2020
Merged

ci: temp fix to exclude build.bat before switching over to actions #239

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6d9d9a
ci: temp fix to exclude build.bat before switching over to actions
stephaniewang526 May 1, 2020
25e1371
update based on comments
stephaniewang526 May 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 4 additions & 24 deletions synth.py
View file
Open in desktop
Expand Up @@ -35,27 +35,7 @@
destination_name='bigquerystorage',
)

java.common_templates()

# TODO: Remove all below s.replace() logic when upstream correction is made in gapic https://github.com/googleapis/gapic-generator/issues/3181
# Remove line added by gapic generator
s.replace("google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/MockBigQueryWriteImpl.java",
"final Object response = responses.remove();",
"")

# Add back lines removed by gapic generator
s.replace("google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/MockBigQueryWriteImpl.java",
"""
public void onNext(AppendRowsRequest value) {
if (response instanceof AppendRowsResponse) {
""",
"""
public void onNext(AppendRowsRequest value) {
requests.add(value);
final Object response = responses.remove();
if (response instanceof AppendRowsResponse) {
"""
)

# Re-run java code formatter after making hacky code change
os.system("mvn com.coveo:fmt-maven-plugin:format")
# TODO: remove this when we switch to actions
stephaniewang526 marked this conversation as resolved.
Show resolved Hide resolved
java.common_templates(excludes=[
'.kokoro/build.bat'
])