Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

fix: try to make test run a bit faster, and update some logs.#279

Merged
stephaniewang526 merged 1 commit intogoogleapis:masterfrom
yirutang:fix-flaky
May 14, 2020
Merged

fix: try to make test run a bit faster, and update some logs.#279
stephaniewang526 merged 1 commit intogoogleapis:masterfrom
yirutang:fix-flaky

Conversation

@yirutang
Copy link
Contributor

Make custom executor no longer pass down to BigQueryWriteClient. The user have a choice of setting a custom BigQueryWriteClient nowadays. The custom executor will only be used in the scope of StreamWriter. This will reduce one test run time by 1 minute.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2020
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #279 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #279      +/-   ##
============================================
- Coverage     74.35%   74.33%   -0.03%     
  Complexity      382      382              
============================================
  Files            45       45              
  Lines          2566     2564       -2     
  Branches        101      101              
============================================
- Hits           1908     1906       -2     
  Misses          604      604              
  Partials         54       54              
Impacted Files Coverage Δ Complexity Δ
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 82.42% <100.00%> (-0.09%) 34.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90ea84a...1c84612. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 4749b85 into googleapis:master May 14, 2020
@yirutang yirutang deleted the fix-flaky branch June 5, 2020 17:35
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants