Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make awaitTermination and shutdown protected, since we already h… #330

Merged
merged 1 commit into from Jun 9, 2020

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Jun 9, 2020

…ave close() method, it is confusing to have 3 shutdown methods

…ave close() method, it is confusing to have 3 shutdown methods
@googlebot googlebot added the cla: yes label Jun 9, 2020
@codecov
Copy link

@codecov codecov bot commented Jun 9, 2020

Codecov Report

No coverage uploaded for pull request base (master@3a5d013). Click here to learn what that means.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #330   +/-   ##
=========================================
  Coverage          ?   75.69%           
  Complexity        ?      465           
=========================================
  Files             ?       54           
  Lines             ?     3119           
  Branches          ?      175           
=========================================
  Hits              ?     2361           
  Misses            ?      652           
  Partials          ?      106           
Impacted Files Coverage Δ Complexity Δ
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 80.89% <40.00%> (ø) 33.00 <5.00> (?)
...age/v1/stub/readrows/ReadRowsRetryingCallable.java 95.23% <0.00%> (ø) 2.00% <0.00%> (?%)
...1beta2/stub/readrows/ReadRowsRetryingCallable.java 95.23% <0.00%> (ø) 2.00% <0.00%> (?%)
.../cloud/bigquery/storage/v1/BigQueryReadClient.java 52.94% <0.00%> (ø) 9.00% <0.00%> (?%)
...uery/storage/v1beta1/stub/BigQueryStorageStub.java 16.66% <0.00%> (ø) 1.00% <0.00%> (?%)
...storage/v1beta2/stub/BigQueryReadStubSettings.java 84.67% <0.00%> (ø) 12.00% <0.00%> (?%)
.../storage/v1beta1/stub/GrpcBigQueryStorageStub.java 93.12% <0.00%> (ø) 12.00% <0.00%> (?%)
...eta1/stub/EnhancedBigQueryStorageStubSettings.java 85.00% <0.00%> (ø) 10.00% <0.00%> (?%)
...1beta1/stub/readrows/ReadRowsRetryingCallable.java 95.23% <0.00%> (ø) 2.00% <0.00%> (?%)
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java 43.90% <0.00%> (ø) 10.00% <0.00%> (?%)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a5d013...bebbec2. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 8856288 into googleapis:master Jun 9, 2020
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants