Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ProtoSchemaConver's problem when converting fields reference same… #428

Merged
merged 2 commits into from Jul 20, 2020

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Jul 16, 2020

… enum types, the generated proto is not buildable.

modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoSchemaConverter.java
modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoSchemaConverterTest.java

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

…e enum types, the generated proto is not buildable.

	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoSchemaConverter.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoSchemaConverterTest.java
@google-cla google-cla bot added the cla: yes label Jul 16, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 16, 2020

Codecov Report

Merging #428 into master will increase coverage by 0.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #428      +/-   ##
============================================
+ Coverage     77.27%   77.29%   +0.01%     
- Complexity      573      577       +4     
============================================
  Files            55       55              
  Lines          3367     3391      +24     
  Branches        198      202       +4     
============================================
+ Hits           2602     2621      +19     
- Misses          661      666       +5     
  Partials        104      104              
Impacted Files Coverage Δ Complexity Δ
...igquery/storage/v1alpha2/ProtoSchemaConverter.java 81.81% <81.81%> (-11.74%) 9.00 <1.00> (+3.00) ⬇️
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 81.07% <0.00%> (+0.70%) 34.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2156fc...6f68949. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 1ce2621 into googleapis:master Jul 20, 2020
13 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 20, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.2.1](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.2.0...v1.2.1) (2020-07-20)


### Bug Fixes

* ProtoSchemaConver's problem when converting fields reference same… ([#428](https://www.github.com/googleapis/java-bigquerystorage/issues/428)) ([1ce2621](https://www.github.com/googleapis/java-bigquerystorage/commit/1ce2621fe633f29c57bc4f4df84b2bcc2c57bdb8))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@yirutang yirutang deleted the fixproto branch Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants