Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v1beta2, v1alpha2 clients #44

Merged
merged 4 commits into from Jan 26, 2020
Merged

feat: add v1beta2, v1alpha2 clients #44

merged 4 commits into from Jan 26, 2020

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jan 24, 2020

Fixes #42
Fixes #43

@googlebot googlebot added the cla: yes label Jan 24, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 24, 2020

Codecov Report

Merging #44 into master will decrease coverage by 3.25%.
The diff coverage is 68.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #44      +/-   ##
============================================
- Coverage     74.87%   71.62%   -3.26%     
- Complexity       97      164      +67     
============================================
  Files            11       23      +12     
  Lines           589     1191     +602     
  Branches          1        3       +2     
============================================
+ Hits            441      853     +412     
- Misses          147      335     +188     
- Partials          1        3       +2
Impacted Files Coverage Δ Complexity Δ
...query/storage/v1alpha2/stub/BigQueryWriteStub.java 16.66% <16.66%> (ø) 1 <1> (?)
...gquery/storage/v1alpha2/BigQueryWriteSettings.java 18.91% <18.91%> (ø) 2 <2> (?)
...uery/storage/v1beta2/BaseBigQueryReadSettings.java 21.21% <21.21%> (ø) 2 <2> (?)
...igquery/storage/v1beta2/stub/BigQueryReadStub.java 25% <25%> (ø) 1 <1> (?)
...bigquery/storage/v1alpha2/BigQueryWriteClient.java 25.8% <25.8%> (ø) 4 <4> (?)
...1alpha2/stub/GrpcBigQueryWriteCallableFactory.java 37.5% <37.5%> (ø) 3 <3> (?)
.../v1beta2/stub/GrpcBigQueryReadCallableFactory.java 37.5% <37.5%> (ø) 3 <3> (?)
...gquery/storage/v1beta2/BaseBigQueryReadClient.java 50% <50%> (ø) 8 <8> (?)
...y/storage/v1alpha2/stub/GrpcBigQueryWriteStub.java 80% <80%> (ø) 8 <8> (?)
...orage/v1alpha2/stub/BigQueryWriteStubSettings.java 81.57% <81.57%> (ø) 14 <14> (?)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e56cdef...48df449. Read the comment docs.

@chingor13 chingor13 changed the title feat: add v1beta2 protos feat: add v1beta2, v1alpha2 clients Jan 24, 2020
@stephaniewang526 stephaniewang526 merged commit 8c124a2 into master Jan 26, 2020
11 of 13 checks passed
@stephaniewang526 stephaniewang526 deleted the v1beta2 branch Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants