deps: upgrade hbase2 to 2.3.6 #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
kolea2
reviewed
Jan 6, 2022
mutianf
force-pushed
the
upgrade-hbase2
branch
from
72ec6e1
to
7027ff4
Compare
mutianf
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
mutianf
force-pushed
the
upgrade-hbase2
branch
2 times, most recently
from
2193b4e
to
e39d26a
Compare
kolea2
approved these changes
Jan 31, 2022
| <dependency> | ||
| <groupId>net.bytebuddy</groupId> | ||
| <artifactId>byte-buddy</artifactId> | ||
| <version>1.12.6</version> |
There was a problem hiding this comment.
nit - I think this is used now in more than one place? Can we extract the version number to a property?
| <google.bigtable.project.id>fake-project</google.bigtable.project.id> | ||
| <google.bigtable.instance.id>fake-instance</google.bigtable.instance.id> | ||
| <google.bigtable.test_env>bigtable</google.bigtable.test_env> |
There was a problem hiding this comment.
This was updated in https://github.com/googleapis/java-bigtable-hbase/pull/3452/files to use bigtable/minicluster instead of connection.impl.. I think I might have missed this pom file
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-api</artifactId> | ||
| <version>1.7.30</version> |
There was a problem hiding this comment.
can we use the variable here?
...arent/bigtable-hbase/src/main/java/org/apache/hadoop/hbase/client/BigtableAsyncRegistry.java
Show resolved
Hide resolved
mutianf
force-pushed
the
upgrade-hbase2
branch
from
621a42c
to
0d4edb3
Compare
gcf-owl-bot
bot
removed
the
owlbot:run
mutianf
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port changes in #3293 and use bytebuddy to resolve hbase backward incompatible changes in
snapshotAsyncmethod and AsyncRegistery class.