-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FuzzyRowFilterAdapter is missing from FilterAdapter #616
Comments
The dependency mismatch issue strikes again. I'm going to have to mull over this one. I'll see what I can do about this, since it's a bit tricky. Perhaps we can use reflection instead of the FuzzyRowFilter proto conversion to get the fuzzyKeysData. I'm not sure that I can fix this problem this week, given the short week, but I'll work on this as a high priority issue and hopefully submit a PR next week. |
There are quite a few issues with our current implementation of the FuzzyRowFilterAdapter. Even once I fix the bugs, we won't be able to easily completely replicate the HBase FuzzyRowFilter implementation. HBase will allow some cases that we won't; specifically, if the row size is smaller than the keys supplied to the filter. In the meantime, you can use a FilterList of RowFilter with RegexStringComparator. |
Thanks for looking into this. |
I still didn't get to this. This will have to come in the next release. |
+1 on this guy as I just learned how wonderfully useful this filter is. |
FuzzyRowFilterAdapter has a couple of problems: 1) It uses the hbase proto conversion to get the "fuzzyKeysDataList." That conversion doesn't work when our shading is combined with non-shaded hbase. Things just don't work. 2) The data and mask were switched in the adapter. see https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L80 for more info. This is the first step towards fixing googleapis#616.
FuzzyRowFilterAdapter has a couple of problems: 1) It uses the hbase proto conversion to get the "fuzzyKeysDataList." That conversion doesn't work when our shading is combined with non-shaded hbase. Things just don't work. 2) The data and mask were switched in the adapter. see https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L80 for more info. This is the first step towards fixing googleapis#616.
I've been trying to get
FuzzyRowFilter
to work, but out of the box I get the following exception:I can see that there's an adapter for it in the codebase but it's not in the filter map within
FileAdapter
. Putting it in the map causes the previous exception to obviously go away but then I get a dependency conflict:This seems to be a subtle dependency issue due to the mismatch between protobuf versions used by HBase and BigTable but all shading attempts on my part have been futile so far. Any idea how I can side-step this issue?
The text was updated successfully, but these errors were encountered: