Moving Status based retries out of ResumingStreamingResultScanner #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AbstractRetryingRpcListener already has handling for handling rpc level retries, and using that method reduces code and allows some interesting changes such as googleapis#703.
googlebot
added
the
cla: yes
We'll have to figure out a way to break this up into smaller PRs.
sduskis
force-pushed
the
reader_retry_listener
branch
from
aece546
to
f79dfb1
Compare
sduskis
added a commit
to sduskis/cloud-bigtable-client
that referenced
this pull request
Dec 20, 2016
This is for future development. See googleapis#1151.
sduskis
added a commit
that referenced
this pull request
Dec 20, 2016
This is for future development. See #1151.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AbstractRetryingRpcListener already has handling for handling rpc level retries, and using that method reduces code and allows some interesting changes such as #703.