Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency for google cloud java bigtable client and deprecate filters related class #1917

Merged
merged 4 commits into from
Sep 4, 2018

Conversation

ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Aug 29, 2018

Add java veneer client dependency and remove duplicate class

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 29, 2018
@sduskis
Copy link
Contributor

sduskis commented Aug 30, 2018

Ugh... I didn't realize that there's a package change. Please reinstate the wrappers.Filters object, mark the class as @Deprecated. In a future PR, please delegate from wrappers.Filters delegate to models.Filters as best as possible.

@ajaaym ajaaym changed the title Add java veneer client dependency and remove duplicate class Add java veneer client dependency and deprecate duplicate class Aug 30, 2018
@ajaaym ajaaym changed the title Add java veneer client dependency and deprecate duplicate class Add dependency for google cloud java bigtable client and deprecate filters related class Sep 4, 2018
@ajaaym ajaaym requested a review from sduskis September 4, 2018 13:18
@sduskis sduskis merged commit b0793ec into googleapis:master Sep 4, 2018
gcf-owl-bot bot added a commit that referenced this pull request Jan 19, 2024
* chore: update java template's license header year

* update year in test files

* remove unwanted file

* compute license year dynamically
Source-Link: googleapis/synthtool@86b9411
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:673eb39211c6d7dc2f037806efe6138637cf9f43c129772981dc78d6f1b83bb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants