Initial commit of Cloud Bigtable/Dataflow connector. #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -0,0 +1,3 @@ | |||
| # Bigtable Dataflow | |||
|
|
|||
| This project contains the core [Bigtable](https://cloud.google.com/bigtable/)-[Dataflow](https://cloud.google.com/dataflow/) integration. The main class you should care about is: [CloudBigtableIO](https://github.com/GoogleCloudPlatform/cloud-bigtable-cdf/blob/master/bigtable-dataflow/src/main/java/com/google/cloud/dataflow/sdk/io/CloudBigtableIO.java). It contains the Cloud Bigtable Sink and Source. | |||
There was a problem hiding this comment.
update link to point to the right repo
| } | ||
|
|
||
| /** | ||
| * Reads rows for a specific {@link Table}, potentially filted by a Scan and/or a start/stop key |
sduskis
force-pushed
the
cdf_connector
branch
2 times, most recently
from
752e59c
to
1c658c0
Compare
| .setProjectId(getProjectId()) | ||
| .setZoneId(getZoneId()) | ||
| .setClusterId(getClusterId()) | ||
| .setUserAgent("CloudBigtableGrpcIO") |
There was a problem hiding this comment.
Maybe mention dataflow? Why IO?
| private static String clusterId = System.getProperty(BIGTABLE_CLUSTER_KEY); | ||
|
|
||
| public static TableName newTestTableName() { | ||
| return TableName.valueOf("test_table-" + UUID.randomUUID().toString()); |
There was a problem hiding this comment.
its useful to specify which test created the table in the name.
|
LGTM |
sduskis
force-pushed
the
cdf_connector
branch
5 times, most recently
from
bda626e
to
b89b829
Compare
sduskis
added a commit
that referenced
this pull request
Aug 20, 2015
Initial commit of Cloud Bigtable/Dataflow connector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.