Using OpenSSL for testing instead of alpn-boot jar #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
remember to remove the following warning: BigtableSession:51 - Could not asynchronously create the ssl context, since ALPN is not installed |
|
@kevinsi4508 and I spoke off line about logging which mode gRPC (alpn-boot vs. tcnactive) is working with. |
sduskis
force-pushed
the
netty-tcnactive
branch
from
c664d85
to
ac4f8b0
Compare
| if (OpenSsl.isAvailable()) { | ||
| LOG.info("gRPC is using the OpenSSL provider"); | ||
| } else { | ||
| LOG.info("gRPC is using the JDK provder"); |
There was a problem hiding this comment.
is that when JDK provider is used, we need to check org.eclipse.jetty.alpn.ALPN ?
if yes, please add : Class.forName("org.eclipse.jetty.alpn.ALPN");
in fact move this if (OpenSsl.isAvailable()) to performWarmup()
There was a problem hiding this comment.
LOG.info("gRPC is using the JDK provider");
sduskis
force-pushed
the
netty-tcnactive
branch
2 times, most recently
from
ce35c9b
to
22f3ab3
Compare
See https://github.com/grpc/grpc-java/blob/master/SECURITY.md for more details See grpc/grpc-java@a99e977 for a change related to the grpc testing envrionment We need to set up our testing environment with OpenSSL 1.0.2 before checking this in Adding logging about the provider type. Reverting bigtable-hbase/pom.xml.
sduskis
force-pushed
the
netty-tcnactive
branch
from
22f3ab3
to
6b1c346
Compare
|
Closing this in favor of other PRs that are more targeted at what we actually need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/grpc/grpc-java/blob/master/SECURITY.md for more details
See grpc/grpc-java@a99e977 for a change related to the grpc testing envrionment
We need to set up our testing environment with OpenSSL 1.0.2 before checking this in.
DO NOT CHECK IN