Logging use of alpn-boot vs. tcnative jar. #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| if (OpenSsl.isAvailable()) { | ||
| LOG.info("gRPC is using the OpenSSL provider (tcnactive jar)"); | ||
| } else { | ||
| LOG.info("gRPC is using the JDK provder (alpn-boot jar)"); |
| sslBuilder = createGrpcSslBuilder(); | ||
| sslBuilder = GrpcSslContexts.forClient().ciphers(null); | ||
| if (OpenSsl.isAvailable()) { | ||
| LOG.info("gRPC is using the OpenSSL provider (tcnactive jar)"); |
There was a problem hiding this comment.
Do we really want to log this multiple times? If not, we can log in performWarmup().
There was a problem hiding this comment.
Yes, I am fine with it. Per connection is OK.
|
LGTM |
sduskis
added a commit
that referenced
this pull request
Oct 12, 2015
Logging use of alpn-boot vs. tcnative jar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few issues related to using the tcnative jar. This one is about logging the use of tcnative or alpn-boot.