test: improve code coverage and lint fixes

Change-Id: I69e1302a3540ceb00960957ae25d98f291059a6f
googleapis · Mar 13, 2021 · d8c2286 · d8c2286
1 parent 040f669
commit d8c2286
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/...-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/EncryptionInfoTest.java b/...-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/EncryptionInfoTest.java
@@ -48,12 +48,12 @@ public void testFromProto() {
             .setMessage("kms is unavailable")
             .build();
 
-    com.google.bigtable.admin.v2.EncryptionInfo proto = com.google.bigtable.admin.v2.EncryptionInfo
-        .newBuilder()
-        .setEncryptionType(EncryptionType.CUSTOMER_MANAGED_ENCRYPTION)
-        .setKmsKeyVersion("some version")
-        .setEncryptionStatus(protoStatus)
-        .build();
+    com.google.bigtable.admin.v2.EncryptionInfo proto =
+        com.google.bigtable.admin.v2.EncryptionInfo.newBuilder()
+            .setEncryptionType(EncryptionType.CUSTOMER_MANAGED_ENCRYPTION)
+            .setKmsKeyVersion("some version")
+            .setEncryptionStatus(protoStatus)
+            .build();
     EncryptionInfo encryptionInfo = EncryptionInfo.fromProto(proto);
 
     assertThat(encryptionInfo.getStatus()).isEqualTo(Status.fromProto(protoStatus));

diff --git a/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/common/StatusTest.java b/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/common/StatusTest.java
@@ -25,6 +25,7 @@
 
 @RunWith(JUnit4.class)
 public class StatusTest {
+
   @Test
   public void testAllCodes() {
     for (Code protoValue : com.google.rpc.Code.values()) {
@@ -65,14 +66,17 @@ public void testFromProto() {
 
   @Test
   public void testToProto() {
+    com.google.rpc.Code code = Code.UNAVAILABLE;
     com.google.rpc.Status proto =
         com.google.rpc.Status.newBuilder()
-            .setCode(Code.UNAVAILABLE.getNumber())
+            .setCode(code.getNumber())
             .setMessage("some message")
             .build();
 
     Status model = Status.fromProto(proto);
+    assertThat(model.getCode().toProto()).isEqualTo(code);
     assertThat(model.toProto()).isEqualTo(proto);
+
     assertThat(model.toString()).isEqualTo(proto.toString());
   }
 }