Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a UUID in the task value #1430

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Sep 27, 2022

The jvmName when calling from cloud function will always be 1@localhost. Add a UUID in the default task value string so we won't have multiple tasks writing to the same stream.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested a review from a team as a code owner September 27, 2022 14:44
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 27, 2022
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3bfc7bc into googleapis:main Sep 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 27, 2022
@mutianf mutianf deleted the fix-uid branch September 27, 2022 16:22
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 27, 2022
🤖 I have created a release *beep* *boop*
---


## [2.13.0](v2.12.0...v2.13.0) (2022-09-27)


### Features

* Add gRPC RLS dependency ([#1248](#1248)) ([e829b92](e829b92))


### Bug Fixes

* Add a UUID in the task value ([#1430](#1430)) ([3bfc7bc](3bfc7bc))


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.4.5 ([#1406](#1406)) ([d906729](d906729))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.14 ([#1411](#1411)) ([ef7d741](ef7d741))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.14 ([#1412](#1412)) ([dcae319](dcae319))
* Update dependency org.junit.vintage:junit-vintage-engine to v5.9.1 ([#1409](#1409)) ([c1e195d](c1e195d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants