Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UpdateAppProfileRequest equals and hashcode should build proto #1142

Merged
merged 4 commits into from
Jan 28, 2022

Conversation

kolea2
Copy link
Collaborator

@kolea2 kolea2 commented Jan 20, 2022

Fixes #1105

@kolea2 kolea2 requested a review from a team as a code owner January 20, 2022 22:24
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Jan 20, 2022
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 20, 2022
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 21, 2022
@kolea2 kolea2 merged commit c9f1ed8 into googleapis:main Jan 28, 2022
@kolea2 kolea2 deleted the app-profile-fix branch January 28, 2022 16:18
This was referenced Jan 28, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 1, 2022
🤖 I have created a release *beep* *boop*
---


### [2.5.2](v2.5.1...v2.5.2) (2022-01-31)


### Bug Fixes

* UpdateAppProfileRequest equals and hashcode should build proto ([#1142](#1142)) ([c9f1ed8](c9f1ed8))


### Dependencies

* **java:** update actions/github-script action to v5 ([#1339](#1339)) ([#1147](#1147)) ([9bfcccf](9bfcccf))
* update actions/github-script action to v5 ([#1146](#1146)) ([9b2c918](9b2c918))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.7.0 ([#1150](#1150)) ([744e483](744e483))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Mar 18, 2022
…oogleapis#1142)

* fix: UpdateAppProfileRequest equals and hashcode should build proto

* lint

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Mar 18, 2022
🤖 I have created a release *beep* *boop*
---


### [2.5.2](googleapis/java-bigtable@v2.5.1...v2.5.2) (2022-01-31)


### Bug Fixes

* UpdateAppProfileRequest equals and hashcode should build proto ([googleapis#1142](googleapis#1142)) ([c9f1ed8](googleapis@c9f1ed8))


### Dependencies

* **java:** update actions/github-script action to v5 ([googleapis#1339](googleapis#1339)) ([googleapis#1147](googleapis#1147)) ([9bfcccf](googleapis@9bfcccf))
* update actions/github-script action to v5 ([googleapis#1146](googleapis#1146)) ([9b2c918](googleapis@9b2c918))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.7.0 ([googleapis#1150](googleapis#1150)) ([744e483](googleapis@744e483))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

equals is broken for UpdateAppProfileRequest
2 participants