Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: java doc update to for returned data instances #165

Merged
merged 3 commits into from Feb 24, 2020
Merged

chore: java doc update to for returned data instances #165

merged 3 commits into from Feb 24, 2020

Conversation

rahulKQL
Copy link
Contributor

Fixes #114

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2020
kolea2
kolea2 reviewed Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add an issue for this in gax to update the Batcher interface?

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Outdated Show resolved Hide resolved
@kolea2
Copy link
Collaborator

kolea2 commented Jan 23, 2020

also - conventional commits check is failing I believe because there is not a space between chore:java...

@rahulKQL
chore: java doc update to for returned data instances
a7fbb0d 
To let the user know about Batcher instance returned from Bulk operations are not threadsafe.
@codecov
Copy link

codecov bot commented Jan 23, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@bc0fb86). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #165   +/-   ##
=========================================
  Coverage          ?   81.92%           
  Complexity        ?      971           
=========================================
  Files             ?       99           
  Lines             ?     6021           
  Branches          ?      330           
=========================================
  Hits              ?     4933           
  Misses            ?      910           
  Partials          ?      178
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 92.3% <ø> (ø) 35 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0fb86...e481b50. Read the comment docs.

@rahulKQL
chore: addressing feedback comments
7a5f8d5 
Added JavaDocs for `BigtableDataClient`.
@rahulKQL rahulKQL changed the title chore:java doc update to for returned data instances chore: java doc update to for returned data instances Jan 23, 2020
@rahulKQL
Copy link
Contributor Author

Thanks for the review, I have addressed previous comments, Please have a fresh look.

@rahulKQL rahulKQL requested a review from kolea2 January 23, 2020 18:58
igorbernstein2
igorbernstein2 reviewed Jan 27, 2020
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but readRows needs a note as well

igorbernstein2
igorbernstein2 approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2020
@igorbernstein2 igorbernstein2 merged commit 525886c into googleapis:master Feb 24, 2020
@yoshi-automation yoshi-automation mentioned this pull request Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

@kolea2 kolea2 Awaiting requested review from kolea2

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update java docs to clarify thread safety of the client
5 participants
@rahulKQL @kolea2 @igorbernstein2 @googlebot @yoshi-kokoro