Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use java helper for templates #220

Merged
merged 1 commit into from Mar 18, 2020
Merged

chore: use java helper for templates #220

merged 1 commit into from Mar 18, 2020

Conversation

chingor13
Copy link
Collaborator

We are cleaning up usage of common templates in synthtool. This allows us the cleanup usage in a centralized place rather than in 60+ repos

@chingor13 chingor13 requested a review from kolea2 March 18, 2020 16:15
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2020
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #220 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #220      +/-   ##
============================================
- Coverage     82.21%   81.93%   -0.29%     
  Complexity      983      983              
============================================
  Files            99       99              
  Lines          6040     6040              
  Branches        332      318      -14     
============================================
- Hits           4966     4949      -17     
- Misses          897      899       +2     
- Partials        177      192      +15     
Impacted Files Coverage Δ Complexity Δ
...igtable/admin/v2/BaseBigtableTableAdminClient.java 58.29% <0.00%> (-4.03%) 50.00% <0.00%> (ø%)
...able/admin/v2/BaseBigtableInstanceAdminClient.java 60.20% <0.00%> (-3.15%) 56.00% <0.00%> (ø%)
...om/google/cloud/bigtable/emulator/v2/Emulator.java 56.52% <0.00%> (-2.61%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c78d84...1ec3cdd. Read the comment docs.

@kolea2 kolea2 merged commit b133827 into master Mar 18, 2020
@kolea2 kolea2 deleted the synth-templates branch March 18, 2020 17:02
yoshi-automation added a commit that referenced this pull request Apr 9, 2020
Source-Repo: googleapis/java-bigtable
Source-Sha: b133827
Source-Link: b133827
Author: Jeff Ching <chingor@google.com>
Date: Wed Mar 18 10:01:58 2020 -0700
Original-Commit-Message: chore: use java helper for templates (#220)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants