Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper scope for DirectPath transitive dependencies #59

Merged
merged 1 commit into from Nov 1, 2019

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Nov 1, 2019

grpc-alts has a transitive dep on grpc-stub, but our tests have a direct dependency on it. This would cause the transitive dependency to be downgraded to the test scope

@googlebot googlebot added the cla: yes label Nov 1, 2019
@igorbernstein2 igorbernstein2 requested a review from kolea2 Nov 1, 2019
@codecov
Copy link

@codecov codecov bot commented Nov 1, 2019

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage     81.29%   81.29%           
  Complexity      937      937           
=========================================
  Files            95       95           
  Lines          5842     5842           
  Branches        325      325           
=========================================
  Hits           4749     4749           
  Misses          917      917           
  Partials        176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 846a44f...a65973a. Read the comment docs.

kolea2
kolea2 approved these changes Nov 1, 2019
@igorbernstein2 igorbernstein2 merged commit 1d1c4de into googleapis:master Nov 1, 2019
12 checks passed
@igorbernstein2 igorbernstein2 deleted the dp-fixes branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants