Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix regression in batch#close silently ignoring entry failures by upgrading to gax to 1.50.0 #67

Merged
merged 1 commit into from Nov 6, 2019

Conversation

kolea2
Copy link
Collaborator

@kolea2 kolea2 commented Nov 6, 2019

No description provided.

@googlebot googlebot added the cla: yes label Nov 6, 2019
@kolea2 kolea2 requested a review from igorbernstein2 Nov 6, 2019
@codecov
Copy link

@codecov codecov bot commented Nov 6, 2019

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage     81.29%   81.29%           
  Complexity      937      937           
=========================================
  Files            95       95           
  Lines          5842     5842           
  Branches        325      325           
=========================================
  Hits           4749     4749           
  Misses          917      917           
  Partials        176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 918f146...6424447. Read the comment docs.

Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

LGTM, but is there any way to make this prominent in the changelog. I would like something like "Fix regression of Batcher.close() failing silently"

@kolea2 kolea2 changed the title deps: upgrade gax to 1.50.0 fix: fix regression in batch#close silently ignoring entry failures by upgrading to gax to 1.50.0 Nov 6, 2019
@kolea2 kolea2 merged commit 5aa8769 into googleapis:master Nov 6, 2019
12 checks passed
@kolea2 kolea2 deleted the gax-update-1.50.0 branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants