Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: addition of billing_account field on Plan #56

Merged
merged 2 commits into from Mar 3, 2021

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Mar 2, 2021

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/ff6f02d7-2420-4d34-b3d1-aeac4153f43d/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 359869792
Source-Link: googleapis/googleapis@c7b5032

docs: clarification that valid address lines are required for all customers

鈥hat valid address lines are required for all customers.

PiperOrigin-RevId: 359869792

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Feb 26 17:19:08 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: c7b5032f6ee39de6c0359b912012f99dfccb49b5
Source-Link: googleapis/googleapis@c7b5032
@yoshi-automation yoshi-automation requested a review from as a code owner Mar 2, 2021
@product-auto-label product-auto-label bot added the api: cloudchannel label Mar 2, 2021
@google-cla google-cla bot added the cla: yes label Mar 2, 2021
@codecov
Copy link

@codecov codecov bot commented Mar 2, 2021

Codecov Report

Merging #56 (db6e683) into master (bcece47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage     82.50%   82.50%           
  Complexity      177      177           
=========================================
  Files             6        6           
  Lines          2183     2183           
  Branches         12       12           
=========================================
  Hits           1801     1801           
  Misses          366      366           
  Partials         16       16           
Impacted Files Coverage 螖 Complexity 螖
...le/cloud/channel/v1/CloudChannelServiceClient.java 82.74% <酶> (酶) 75.00 <0.00> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update bcece47...0faf7a0. Read the comment docs.

@chingor13 chingor13 changed the title feat: addition of billing_account field on Plan. docs: clarification that valid address lines are required for all customers. feat: addition of billing_account field on Plan Mar 2, 2021
@chingor13 chingor13 added the automerge label Mar 2, 2021
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Mar 3, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Mar 3, 2021
@Neenu1995 Neenu1995 added the automerge label Mar 3, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit fdc2ad6 into master Mar 3, 2021
15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the autosynth-googleapis branch Mar 3, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Mar 3, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 27, 2021
馃 I have created a release \*beep\* \*boop\*
---
## [2.1.0](https://www.github.com/googleapis/java-channel/compare/v2.0.1...v2.1.0) (2021-04-23)


### Features

* Added legacy_sku field to TransferableSku ([3e0defe](https://www.github.com/googleapis/java-channel/commit/3e0defedb743a243e78fc307ae325ab939056dde))
* Adding customer level pubsub events for primary domain verification and primary domain change ([3e0defe](https://www.github.com/googleapis/java-channel/commit/3e0defedb743a243e78fc307ae325ab939056dde))
* addition of billing_account field on Plan ([#56](https://www.github.com/googleapis/java-channel/issues/56)) ([fdc2ad6](https://www.github.com/googleapis/java-channel/commit/fdc2ad62d253f36dcd55c0f3bb69138f4dea29cd))
* Enabled support for boolean as an allowed parameter value ([3e0defe](https://www.github.com/googleapis/java-channel/commit/3e0defedb743a243e78fc307ae325ab939056dde))
* **generator:** update protoc to v3.15.3 ([#54](https://www.github.com/googleapis/java-channel/issues/54)) ([bcece47](https://www.github.com/googleapis/java-channel/commit/bcece4727fd0f832a29b0f293b1f983cf0af0d8f))


### Bug Fixes

* release scripts from issuing overlapping phases ([#74](https://www.github.com/googleapis/java-channel/issues/74)) ([72667e2](https://www.github.com/googleapis/java-channel/commit/72667e228ddfa96f9e9965b7b63cf2258a3627e3))
* typo ([#72](https://www.github.com/googleapis/java-channel/issues/72)) ([dc27217](https://www.github.com/googleapis/java-channel/commit/dc27217a2e32d20c83784dc69bff24598dae25a3))


### Documentation

* clarification that valid address lines are required for all customers ([fdc2ad6](https://www.github.com/googleapis/java-channel/commit/fdc2ad62d253f36dcd55c0f3bb69138f4dea29cd))
* Update documentation comments to match tone and style with the rest of Cloud documentation ([#69](https://www.github.com/googleapis/java-channel/issues/69)) ([3e0defe](https://www.github.com/googleapis/java-channel/commit/3e0defedb743a243e78fc307ae325ab939056dde))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.20.1 ([#61](https://www.github.com/googleapis/java-channel/issues/61)) ([b532007](https://www.github.com/googleapis/java-channel/commit/b532007fd7afbf0b905e3432a02401b8feaef4a5))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.21.0 ([#70](https://www.github.com/googleapis/java-channel/issues/70)) ([93fde13](https://www.github.com/googleapis/java-channel/commit/93fde137961babee0b099e2e8d8ebcb1c2b1d5c9))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.21.1 ([#75](https://www.github.com/googleapis/java-channel/issues/75)) ([5686118](https://www.github.com/googleapis/java-channel/commit/5686118e7c2b3477d5d1081cfb512b655412418a))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v1 ([#79](https://www.github.com/googleapis/java-channel/issues/79)) ([84f0ac3](https://www.github.com/googleapis/java-channel/commit/84f0ac3e8a5f81f1c73beb816f04b64142bc59b7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudchannel cla: yes context: full
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants