ci: add Github Actions workflow to check convergence in a release PR #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
.github/workflows/dashboard.yaml
Outdated
| @@ -13,4 +13,41 @@ jobs: | |||
| with: | |||
| java-version: 8 | |||
| - run: java -version | |||
| - run: .kokoro/dashboard.sh | |||
|
|
|||
| converge: | |||
There was a problem hiding this comment.
Let's be more specific here: dependency-convergence-check.
.github/workflows/dashboard.yaml
Outdated
| with: | ||
| java-version: 8 | ||
| script: | | ||
| // only approve PRs from release-please |
There was a problem hiding this comment.
Suggested change
| // only approve PRs from release-please | |
| // only checks PRs from release-please |
.github/workflows/dashboard.yaml
Outdated
| return; | ||
| } | ||
|
|
||
| // only approve PRs like "chore: release <release version>" |
There was a problem hiding this comment.
Suggested change
| // only approve PRs like "chore: release <release version>" | |
| // only checks PRs like "chore: release <release version>" |
.github/workflows/dashboard.yaml
Outdated
| return; | ||
| } | ||
|
|
||
| // only approve PRs with README.md, CHANGELOG.md, pom.xml and versions.txt changes |
There was a problem hiding this comment.
Suggested change
| // only approve PRs with README.md, CHANGELOG.md, pom.xml and versions.txt changes | |
| // only checks PRs with README.md, CHANGELOG.md, pom.xml and versions.txt changes |
.kokoro/dashboard.sh
Outdated
| RETURN_CODE=${INSTALL_RETURN_CODE} | ||
|
|
||
| case ${JOB_TYPE} in | ||
| converge) |
There was a problem hiding this comment.
please update this accordingly
.github/workflows/dashboard.yaml
Outdated
| if (files.size != 4 || !files.has("README.md") || !files.has("CHANGELOG.md") || !files.has("pom.xml") || !files.has("versions.txt")) { | ||
| return; | ||
| } | ||
| - run: java -version | ||
| - run: .kokoro/dashboard.sh |
There was a problem hiding this comment.
if you are checking JOB_TYPE in dashboard.sh, you would need to add the env var here:
env:
JOB_TYPE: convergence
.kokoro/dashboard.sh
Outdated
Comment on lines
35
to
43
| CONVERGE_RETURN_CODE=$? | ||
| if [[ $INSTALL_RETURN_CODE -eq 0 ]] | ||
| then | ||
| RETURN_CODE=${CONVERGE_RETURN_CODE} | ||
| fi | ||
| ;; | ||
| esac | ||
|
|
||
| echo "exiting with ${RETURN_CODE}" |
There was a problem hiding this comment.
This would only tell you if the report was built successfully or not (which is important) but I'm not seeing the output being checked.
Ideally, if we have full convergence, the script should exit with 0 and output Shared dependencies converge \o/. Otherwise, it should exit with error code 1 and a list of clients that are not converging (which is already being output by the report).
stephaniewang526
approved these changes
Mar 22, 2021
chingor13
requested changes
Mar 22, 2021
dashboard/src/main/java/com/google/cloud/tools/opensource/cloudbomdashboard/DashboardMain.java
Outdated
Show resolved
Hide resolved
chingor13
requested changes
Mar 22, 2021
Comment on lines
+44
to
+47
| while IFS= read -r line; do | ||
| echo "$line" | ||
| LINE_COUNT=$((LINE_COUNT+1)) | ||
| done < "$outputFile" |
There was a problem hiding this comment.
If you're just counting lines - cat "${outputFile}" | wc -l
chingor13
reviewed
Mar 23, 2021
dashboard/src/main/java/com/google/cloud/tools/opensource/cloudbomdashboard/DashboardMain.java
Outdated
Show resolved
Hide resolved
dashboard/src/main/java/com/google/cloud/tools/opensource/cloudbomdashboard/DashboardMain.java
Outdated
Show resolved
Hide resolved
chingor13
approved these changes
Mar 23, 2021
…-bom into convergence-ci-add
chingor13
approved these changes
Mar 23, 2021
Neenu1995
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jan 19, 2023
…mplates/java_library/.kokoro (#1752) build(deps): bump protobuf Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 3.20.1 to 3.20.2. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py) - [Commits](protocolbuffers/protobuf@v3.20.1...v3.20.2) --- updated-dependencies: - dependency-name: protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Source-Link: googleapis/synthtool@239f962 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d5da32501662e4e53365220cc14cfb1d3b9446585397d57dac50171d92556ae7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.