test: fix build #219
Closed
test: fix build #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
=========================================
Coverage 37.18% 37.18%
Complexity 15148 15148
=========================================
Files 1660 1660
Lines 192858 192858
Branches 28404 28404
=========================================
Hits 71716 71716
Misses 112814 112814
Partials 8328 8328 Continue to review full report at Codecov.
|
product-auto-label
bot
added
the
api: compute
AVaksman
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chingor13
requested changes
Oct 27, 2020
Comment on lines
-150
to
-152
| Calendar calendar = Calendar.getInstance(); | ||
| calendar.add(Calendar.HOUR_OF_DAY, -1); | ||
| Timestamp cutoff = Timestamp.of(calendar.getTime()); |
There was a problem hiding this comment.
This cleanUpNetworks was here to delete old networks that are not cleaned up in previous test runs. We have a hard limit of ~10 networks on the project which cannot be changed.
|
@twinkle-kadia could you please take a look at this? This is blocking the release. Thank you! |
|
@twinkle-kadia gentle ping! |
|
#200 is closed. This seems unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #200