Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Regenerate latest version of the client with field presence support #401

Merged
merged 5 commits into from
May 10, 2021

Conversation

vam-google
Copy link
Contributor

No description provided.

@vam-google vam-google requested a review from a team as a code owner May 10, 2021 08:17
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/java-compute API. label May 10, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2021
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/release-please.yml
  • .github/workflows/auto-release.yaml
  • .github/workflows/ci.yaml
  • .kokoro/build.sh
  • .kokoro/dependencies.sh
  • .kokoro/release/publish_javadoc.cfg
  • .kokoro/release/publish_javadoc.sh
  • .kokoro/release/snapshot.sh
  • .kokoro/release/stage.sh
  • LICENSE

@vam-google vam-google requested a review from chingor13 May 10, 2021 08:19
…elist

This is totally expected, since it is an alpha client and both of those errors (`6003` - public constant value change, and `7012` - addition of a method to an interface) are expected given the underlying change. Specifially the `optional` keyword was added to `compute.proto`, which caused addition of `has<FieldName>()` methods to proto stubs and respective builders (error 7012). The field numbers change (error `6003`) was caused by the rollback of the previous hack (googleapis/googleapis-discovery#31) which, in its turn, was caused by a bug in protobuf.
@vam-google vam-google requested a review from Neenu1995 May 10, 2021 17:13
@vam-google vam-google merged commit 6e46502 into googleapis:diregapic May 10, 2021
Neenu1995 added a commit that referenced this pull request May 10, 2021
This pull request was generated using releasetool.

05-10-2021 16:14 PDT

chore: Update google-cloud-shared-dependencies dependency to 1.1.0 (#407)
feat: Regenerate latest version of the client with field presence support (#401)
test: commit integration tests by georgiyekkert (#319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the googleapis/java-compute API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants