Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix gcloud SDK detection on Windows #384

merged 1 commit into from Feb 24, 2021


Copy link

@kevin-wise kevin-wise commented Feb 23, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #383

Copy link

@google-cla google-cla bot commented Feb 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 23, 2021
Copy link

@codecov codecov bot commented Feb 23, 2021

Codecov Report

Merging #384 (ab2e2db) into master (09fac9d) will increase coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #384      +/-   ##
+ Coverage     67.60%   67.74%   +0.13%     
  Complexity      384      384              
  Files            36       36              
  Lines          1985     1981       -4     
  Branches        268      267       -1     
  Hits           1342     1342              
+ Misses          535      531       -4     
  Partials        108      108              
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/testing/ 32.16% <0.00%> (+0.73%) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09fac9d...7ca3218. Read the comment docs.

Copy link
Contributor Author

@kevin-wise kevin-wise commented Feb 23, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 23, 2021
@kevin-wise kevin-wise marked this pull request as ready for review Feb 24, 2021
@kevin-wise kevin-wise requested a review from as a code owner Feb 24, 2021
Copy link
Contributor Author

@kevin-wise kevin-wise commented Feb 24, 2021

Cut a local build and tested with my project, it seems to work as intended.

@chingor13 chingor13 changed the title Fix GCloud detection on Windows fix: fix gcloud SDK detection on Windows Feb 24, 2021
@chingor13 chingor13 added automerge kokoro:force-run labels Feb 24, 2021
Copy link

@chingor13 chingor13 commented Feb 24, 2021

Thanks for the patch!

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Feb 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9545442 into googleapis:master Feb 24, 2021
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Feb 24, 2021
@kevin-wise kevin-wise deleted the patch-1 branch Feb 24, 2021
Copy link
Contributor Author

@kevin-wise kevin-wise commented Feb 24, 2021

@chingor13 thanks for merging. This is my first time contributing to this project. What is the release schedule? Or when can I expect this fix to be released?

gcf-merge-on-green bot pushed a commit that referenced this issue Mar 1, 2021
🤖 I have created a release \*beep\* \*boop\* 
### [1.94.2]( (2021-03-01)

### Bug Fixes

* fix gcloud SDK detection on Windows ([#384]( ([9545442](, closes [#383](

### Dependencies

* switch from Jackson to GSON ([#368]( ([220df17](
* update dependency to v1.31.2 ([#359]( ([107a32a](
* update dependency to v1.62.0 ([2374ca7](
* update dependency to v2.1.0 ([#387]( ([c55f950](
* update dependency to v1.0.10 ([#392]( ([45b5abf](
* update dependency to v1.0.5 ([#345]( ([0a5596d](
* update dependency to v1.0.7 ([#357]( ([3c2b7b4](
* update dependency to v1.0.9 ([#372]( ([82840da](
* update dependency to v0.22.2 ([#343]( ([3b418f7](
* update dependency to v0.23.0 ([#364]( ([7d52e06](
* update dependency to v0.24.0 ([#382]( ([44d8d02](
* update dependency to v2.5.1 ([#354]( ([e7a688c](
* update dependency to v30.1-android ([#348]( ([0f2eadd](
* update dependency to v1.38.1 ([#358]( ([8fdc254](
* update dependency to v1.39.0 ([2374ca7](
* update dependency to v3.15.0 ([#378]( ([4314da9](
* update dependency to v3.15.1 ([#381]( ([09fac9d](
* update dependency to v3.15.2 ([#385]( ([8c2c179](
* update dependency to v3.15.3 ([#391]( ([6e03ce5](
* update dependency io.grpc:grpc-bom to v1.34.1 ([#342]( ([b80c3da](
* update dependency opencensus to v0.28.0 ([2374ca7](
* update io.grpc:grpc-bom to v1.36.0 ([#389]( ([2374ca7](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes
None yet

Successfully merging this pull request may close these issues.

3 participants