Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use sdk-platform-java-config to consolidate build configs #1307

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Jan 29, 2024

Notable Changes:

  1. Use gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform* docker images for Kokoro GraalVM tests instead of gcr.io/cloud-devrel-kokoro-resources/graalvm*.
  2. Use com.google.cloud:sdk-platform-java-config as the parent which inherits configs from java-shared-config and hosts the google-cloud-shared-dependencies version under the google-cloud-shared-dependencies.version property. This artifact is versioned to be the same as google-cloud-shared-dependencies.
  3. Adjust renovate-bot settings to update docker images when a new version of sdk-platfrom-java-config is on Maven Central.

Example renovate-bot update PR in google-cloud-java: googleapis/google-cloud-java#10290

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 29, 2024
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/presubmit/graalvm-native.cfg
  • renovate.json

@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label Jan 29, 2024
@mpeddada1 mpeddada1 marked this pull request as ready for review January 30, 2024 15:10
@mpeddada1 mpeddada1 requested review from a team as code owners January 30, 2024 15:10
Copy link
Collaborator

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one nit

pom.xml Show resolved Hide resolved
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2024
@kolea2 kolea2 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 30, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2024
@kolea2 kolea2 removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 30, 2024
@kolea2
Copy link
Collaborator

kolea2 commented Jan 30, 2024

@mpeddada1 it looks like owlbot reverted the renovate config changes - can you exclude them or should these be added upstream instead?

@mpeddada1
Copy link
Contributor Author

Good catch, @kolea2! Let me try doing a one time update in synthtool: googleapis/synthtool#1921

@mpeddada1 mpeddada1 merged commit c201367 into main Jan 30, 2024
22 checks passed
@mpeddada1 mpeddada1 deleted the atomic-updates-graalvm branch January 30, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants