-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use sdk-platform-java-config to consolidate build configs #1307
Conversation
Warning: This pull request is touching the following templated files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with one nit
@mpeddada1 it looks like owlbot reverted the renovate config changes - can you exclude them or should these be added upstream instead? |
Good catch, @kolea2! Let me try doing a one time update in synthtool: googleapis/synthtool#1921 |
…ic-updates-graalvm
…atastore into atomic-updates-graalvm
Notable Changes:
gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform*
docker images for Kokoro GraalVM tests instead ofgcr.io/cloud-devrel-kokoro-resources/graalvm*
.com.google.cloud:sdk-platform-java-config
as the parent which inherits configs fromjava-shared-config
and hosts thegoogle-cloud-shared-dependencies
version under thegoogle-cloud-shared-dependencies.version
property. This artifact is versioned to be the same as google-cloud-shared-dependencies.sdk-platfrom-java-config
is on Maven Central.Example renovate-bot update PR in google-cloud-java: googleapis/google-cloud-java#10290