Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding Commit RPC Trace instrumentation #1439

Closed
wants to merge 19 commits into from
Closed

feat: Adding Commit RPC Trace instrumentation #1439

wants to merge 19 commits into from

Conversation

jimit-j-shah
Copy link

@jimit-j-shah jimit-j-shah commented May 15, 2024 •
edited

  • Added end-to-end test for Datastore operationsput, add, update and delete.
  • Updated E2E Test to use the namespace correctly for efficient clean-up of test data

Fixes #1428 ☕️

@jimit-j-shah
feat: Adding Lookup RPC OpenTelemetry Tracing
af564e6 
- Removed OpenCensus Tracing
- Added E2E tests with Global and Local OTel SDK
@jimit-j-shah
Fixing dependencies
8994041
@jimit-j-shah
feat: Adding Lookup RPC OpenTelemetry Tracing
6f6ad7b 
- Removed OpenCensus Tracing
- Added E2E tests with Global and Local OTel SDK
@jimit-j-shah
Merge remote-tracking branch 'origin/jimit/lookup-trace-3' into jimit…
cd69545 
…/lookup-trace-3
@jimit-j-shah
Fixing depenency
e6f5ae9
@jimit-j-shah
Code review: Add BOM as dependency
766199f
@jimit-j-shah
Code Review: s/FIRESTORE/DATASTORE
5a836d0
@jimit-j-shah
Code review: rename ITE2ETracingTest.java AbstractITE2ETracingTest.java
83dc603
@jimit-j-shah
Code review: fixing pom.xml
8d6d2da
@jimit-j-shah
Code review: fixing dependencies
9cfdfb6
@jimit-j-shah
Code review: pom dependency scope
4442c81
@jimit-j-shah
Code review: Parameterize ITE2ETracingTest.java
ce973dd
@jimit-j-shah
Code review: parameterizing db names
e37c541
@jimit-j-shah
formatting
dbb5108
@jimit-j-shah
code review: style
153b11f
@jimit-j-shah
Code review: Add common functionality to RemoteDatastoreHelper
4660b0b
@jimit-j-shah
Code review: clean up personal changes
c7b80dd
@jimit-j-shah
feat: Adding Commit RPC Trace instrumentation
f2a27bd
@jimit-j-shah jimit-j-shah requested review from a team as code owners May 15, 2024 20:00
@jimit-j-shah jimit-j-shah self-assigned this May 15, 2024
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label May 15, 2024
@jimit-j-shah jimit-j-shah added api: datastore Issues related to the googleapis/java-datastore API. and removed size: l Pull request size is large. labels May 15, 2024
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label May 15, 2024
@jimit-j-shah jimit-j-shah changed the base branch from tracing-main to jimit/lookup-trace-3 May 15, 2024 20:23
Base automatically changed from jimit/lookup-trace-3 to tracing-main May 15, 2024 21:57
@jimit-j-shah
Copy link
Author

Abandoning this PR - will send another one.

@jimit-j-shah jimit-j-shah reopened this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 Awaiting requested review from kolea2

@cindy-peng cindy-peng Awaiting requested review from cindy-peng

Assignees

@jimit-j-shah jimit-j-shah

Labels
api: datastore Issues related to the googleapis/java-datastore API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jimit-j-shah