Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RunAggregationQuery instrumentation #1447

Merged
merged 12 commits into from
May 23, 2024

Conversation

jimit-j-shah
Copy link

  • Added tracing instrumentation and test for runAggregationQuery operation.
  • Retired open census instrumentation and test expectations
  • Will add hermetic integration tests using OpenTelemetry InMemorySpanExporter in a future CL (after all RPCs have been tested E2E) to replace the verification in RetryAndTraceDatastoreRpcDecorator.java.

Fixes #1428 ☕️

@jimit-j-shah jimit-j-shah requested review from a team as code owners May 16, 2024 23:17
@jimit-j-shah jimit-j-shah self-assigned this May 16, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/java-datastore API. labels May 16, 2024
Base automatically changed from jimit/runquery-trace-1 to tracing-main May 23, 2024 17:15
@jimit-j-shah jimit-j-shah merged commit 8c4a832 into tracing-main May 23, 2024
16 checks passed
@jimit-j-shah jimit-j-shah deleted the jimit/aggreagationquery-trace-2 branch May 23, 2024 17:46
jimit-j-shah added a commit that referenced this pull request Jun 13, 2024
* feat: RunQuery trace instrumentation

* Formatting

* Formatting

* Refactor: s/RUNQUERY/RUN_QUERY

* feat: RunAggregationQuery Trace Instrumentation

* Build: retiring test assertions for OpenCensus spans - will be replacing this in hermetic integration tests for OpenTelemetry using in-memory span exports (in addition to ITE2ETraceTest.java).

* Formatting

* Fixing @test annotation missed after merge

* Formatting
jimit-j-shah added a commit that referenced this pull request Jun 18, 2024
* feat: RunQuery trace instrumentation

* Formatting

* Formatting

* Refactor: s/RUNQUERY/RUN_QUERY

* feat: RunAggregationQuery Trace Instrumentation

* Build: retiring test assertions for OpenCensus spans - will be replacing this in hermetic integration tests for OpenTelemetry using in-memory span exports (in addition to ITE2ETraceTest.java).

* Formatting

* Fixing @test annotation missed after merge

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants