Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency com.google.guava:guava-bom to v28.2-android #16

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Jan 7, 2020

This PR contains the following updates:

Package Update Change
com.google.guava:guava-bom minor 28.1-android -> 28.2-android

The new version of Guava no longer has a dependency on org.codehaus.mojo:animal-sniffer-annotations
Fixes #3

@athakor athakor added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 8, 2020
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #16 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
+ Coverage     81.62%   81.75%   +0.13%     
  Complexity      532      532              
============================================
  Files            46       46              
  Lines          2286     2286              
  Branches        251      251              
============================================
+ Hits           1866     1869       +3     
+ Misses          300      297       -3     
  Partials        120      120
Impacted Files Coverage Δ Complexity Δ
.../cloud/datastore/testing/LocalDatastoreHelper.java 85.07% <0%> (+4.47%) 17% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bbe181...8516085. Read the comment docs.

@athakor athakor added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 8, 2020
@BenWhitehead BenWhitehead changed the title fix: remove temporary added animal-sniffer-annotations exclusion rule from pom deps: update dependency com.google.guava:guava-bom to v28.2-android Jan 9, 2020
@BenWhitehead
Copy link
Collaborator

OS X Build issues are not related to the PR and have been addressed separately.

@BenWhitehead BenWhitehead merged commit fde0a9f into googleapis:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporary animal-sniffer-annotations exclusion rules in poms
3 participants