Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: Add sample snippets for count aggregations #871

Merged
merged 88 commits into from Oct 21, 2022
Merged

samples: Add sample snippets for count aggregations #871

merged 88 commits into from Oct 21, 2022

Conversation

jainsahab
Copy link
Member

@jainsahab jainsahab commented Oct 10, 2022 •
edited

This PR contains the samples for Query count feature.

@jainsahab
Add method in Datastore client to invoke rpc for aggregation query
ce4c149
@jainsahab
Creating count aggregation and using it to populate Aggregation proto
100115f
@jainsahab
Moving aggregation builder method to root level aggregation class
c1956d8
@jainsahab
Introducing RecordQuery to represent queries which returns entity rec…
493edfa 
…ords when executed
@jainsahab
Updating gitignore with patch extension
9c7c4ba
@jainsahab
Setting up structure of Aggregation query and its builder
cf49a37
@jainsahab
Introducing ProtoPreparer to populate the request protos
78fd6c9
@jainsahab
Delegating responsibility of preparing query proto to QueryPreparer
2ae957a
@jainsahab
Populating aggregation query with nested structured query
14ac55f
@jainsahab
Delegating responsibility of preparing query proto in GqlQuery to Que…
3ff182f 
…ryPreparer
@jainsahab
Removing RecordQuery from the query hierarchy and making it a standal…
7de95e6 
…one interface for now
@jainsahab
Populating aggregation query with nested gql query
d62964f
@jainsahab
Removing deprecation warning by using assertThrows instead of Expecte…
1f5b1a4 
…dException rule
@jainsahab
Making DatastoreRpc call aggregation query method on client
b69b166
@jainsahab
Creating response transformer to transform aggregation query response…
9589f5c 
… into domain objects
@jainsahab
Implementing aggregation query executor to execute AggergationQuery
2103b80
@jainsahab
Adding missing assertion statements
775c341
@jainsahab
Creating RetryExecutor to inject it as a dependency in other components
8872a55
@jainsahab
Making RetryExecutor accept RetrySettings when creating it
1dfafb7
@jainsahab
Revert "Making RetryExecutor accept RetrySettings when creating it"
f6bf0ce 
This reverts commit 1dfafb7.
@jainsahab
Revert "Creating RetryExecutor to inject it as a dependency in other …
deb63bf 
…components"

This reverts commit 8872a55.
@jainsahab
Introducing RetryAndTraceDatastoreRpcDecorator to have retry and trac…
428e9e3 
…eability logic on top of another DatastoreRpc
@jainsahab
Extracting out the responsibility of preparing ReadOption in it's own…
c86913e 
… ProtoPreparer
@jainsahab
Making QueryExecutor to execute query with provided ReadOptions
b235935
@jainsahab
Exposing readTime to the user
f1c3379
@jainsahab
Ignoring runAggregationQuery method from clirr check
168b864
@jainsahab
Making readTime final
005429b
@jainsahab
Allowing namespace to be optional in AggregationQuery
dfbdf60
@jainsahab
Add capability to fetch aggregation result by passing alias
0565ba6
@jainsahab
Implementing User facing datastore.runAggrgation method to run aggreg…
0e8e7b9 
…ation query
Sita04
Sita04 requested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@Sita04 Sita04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the samples. Left a few comments.

jainsahab and others added 10 commits October 19, 2022 17:05
@jainsahab @Sita04
Moving comment to the top of statement.
670face 
Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
@jainsahab @Sita04
Making builder syntax multiline
67b2602 
Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
@jainsahab @Sita04
Adding comment describing the purpose of GQL query
ebc998d 
Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
@jainsahab @Sita04
Rephrasing the comment
9988599 
Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
@jainsahab @Sita04
Adding a comment describing the purpose of the GQL query
c3fa6d7 
Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
@jainsahab @Sita04
Rephrasing the comment
11a4230 
Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
@jainsahab
Relocating region tags to include import statments
7189f80
@jainsahab
Few styling and comment fixes
350ab61
@jainsahab
Adding comment in the transaction block
abd2b95
@jainsahab
Adding fullstop to the comment lines
1adf105
@Sita04 Sita04 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 21, 2022
@jainsahab jainsahab added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 21, 2022
@jainsahab jainsahab added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 21, 2022
@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Oct 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 21, 2022
@kolea2 kolea2 merged commit cf9983d into googleapis:main Oct 21, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlara310 jlara310 jlara310 left review comments

@Sita04 Sita04 Sita04 approved these changes

@kolea2 kolea2 kolea2 approved these changes

Assignees

@Sita04 Sita04

Labels
api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jainsahab @Sita04 @jlara310 @kolea2 @yoshi-kokoro