refactor: Extracting out Proto preparation logic to encourage reusability #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
changed the title
kolea2
requested changes
Oct 13, 2022
google-cloud-datastore/src/main/java/com/google/cloud/datastore/GqlQuery.java
Show resolved
Hide resolved
google-cloud-datastore/src/main/java/com/google/cloud/datastore/ReadOptionProtoPreparer.java
Show resolved
Hide resolved
…mentation details
product-auto-label
bot
added
size: l
kolea2
approved these changes
Oct 14, 2022
jainsahab
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
jainsahab
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a component called ProtoPreparer which will be used to populate the protos from the domain objects. In the upcoming count aggregation feature, aggregation query will be acting upon StructuredQuery and GqlQuery and hence need to populate the protos of those queries again. For that reason ProtoPreparer component will have the responsibility to populate the protos and be reused in multiple usecases.
Note: This PR is intended to trim down the changes done as part of #823 .