fix: block close() on the termination of all RPC channels

googleapis · Jan 26, 2021 · 2944191 · 2944191
1 parent 0e6f3da
commit 2944191
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/spi/v1/GrpcFirestoreRpc.java b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/spi/v1/GrpcFirestoreRpc.java
@@ -66,6 +66,7 @@
 import java.io.IOException;
 import java.util.Collections;
 import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
 
 /**
  * GRPC client implementation of the Firestore RPC methods. Exposes FirestoreOptions on top of the
@@ -152,6 +153,9 @@ public void close() throws Exception {
     for (BackgroundResource resource : clientContext.getBackgroundResources()) {
       resource.close();
     }
+    for (BackgroundResource resource : clientContext.getBackgroundResources()) {
+      resource.awaitTermination(1, TimeUnit.SECONDS);
+    }
     executorFactory.release(executor);
   }