Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change REST binding for ListDocuments to support root collection #900

Merged
merged 4 commits into from
Mar 30, 2022
Merged

fix: change REST binding for ListDocuments to support root collection #900

merged 4 commits into from
Mar 30, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Mar 4, 2022 •
edited
Loading

  • Regenerate this pull request now.

PiperOrigin-RevId: 432504691

Source-Link: googleapis/googleapis@3db3087

Source-Link: https://github.com/googleapis/googleapis-gen/commit/80f0375a1a82460532422e504a41ef2a3e2f72e1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODBmMDM3NWExYTgyNDYwNTMyNDIyZTUwNGE0MWVmMmEzZTJmNzJlMSJ9

@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners March 4, 2022 21:49
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 4, 2022
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Mar 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2022
@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Mar 8, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 8, 2022
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Mar 8, 2022

Owl bot is regenerating pull request 900...
Build name: OTc1MDA5YTktOWU4ZC00MDc0LTg1ZDgtZjMwNDJkNjUzMGQ3

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@SurferJeffAtGoogle SurferJeffAtGoogle added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2022
SurferJeffAtGoogle added a commit to SurferJeffAtGoogle/repo-automation-bots that referenced this pull request Mar 8, 2022
@SurferJeffAtGoogle
Revert "feat(owl-bot): combine pull requests for monorepos (googleapi…
f383763 
…s#3250)"

This reverts commit 01d887e.

I think I broke the regenerate checkbox.
I tried regenerating googleapis/java-firestore#900 and the result was broken.
@SurferJeffAtGoogle SurferJeffAtGoogle mentioned this pull request Mar 8, 2022
Merged
@SurferJeffAtGoogle SurferJeffAtGoogle self-assigned this Mar 8, 2022
SurferJeffAtGoogle
SurferJeffAtGoogle suggested changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@SurferJeffAtGoogle SurferJeffAtGoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regenerating the PR did not work as intended.

SurferJeffAtGoogle added a commit to googleapis/repo-automation-bots that referenced this pull request Mar 8, 2022
@SurferJeffAtGoogle
Revert "feat(owl-bot): combine pull requests for monorepos (#3250)" (#…
d5dd2b2 
…3272)

This reverts commit 01d887e.

I think I broke the regenerate checkbox.
I tried regenerating googleapis/java-firestore#900 and the result was broken.
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Mar 8, 2022

Owl bot is regenerating pull request 900...
Build name: ZTQxNWYwYzgtMmRiMC00ZTcyLWI0YmMtNmZmNzEzZTZmYWNi

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Mar 8, 2022

Owl bot is regenerating pull request 900...
Build name: OTBhMWUzODMtMzUyMi00ZjZhLWI1YTItOWRmYzY3Y2RmMWEy

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@kolea2 kolea2 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 8, 2022
@SurferJeffAtGoogle
Copy link
Contributor

FYI, this PR has been a test case for some changes to owl-bot. I apologize for the confusion. I'll merge it now as soon as tests pass.

@SurferJeffAtGoogle
Copy link
Contributor

FYI, this PR has been a test case for some changes to owl-bot. I apologize for the confusion. I'll merge it now as soon as tests pass.

Actually, I'll just leave it alone now and allow the owners to merge. No more nonsense from Owl Bot.

@SurferJeffAtGoogle SurferJeffAtGoogle mentioned this pull request Mar 8, 2022
Merged
@SurferJeffAtGoogle SurferJeffAtGoogle removed their assignment Mar 8, 2022
@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Mar 10, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 11, 2022
@suztomo suztomo closed this Mar 14, 2022
@Neenu1995 Neenu1995 reopened this Mar 14, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2022
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Mar 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2022
@suztomo suztomo added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 18, 2022
@Neenu1995 Neenu1995 merged commit aabd4ac into main Mar 30, 2022
@Neenu1995 Neenu1995 deleted the owl-bot-copy branch March 30, 2022 17:14
@release-please release-please bot mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SurferJeffAtGoogle SurferJeffAtGoogle SurferJeffAtGoogle approved these changes

@Neenu1995 Neenu1995 Neenu1995 approved these changes

@meltsufin meltsufin meltsufin approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/java-firestore API. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SurferJeffAtGoogle @Neenu1995 @meltsufin @schmidt-sebastian @suztomo @yoshi-kokoro @kolea2