-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make FirestoreException factory methods public to allow construction for testing #477
Merged
BenWhitehead
merged 1 commit into
googleapis:master
from
BenWhitehead:public-firestore-exception-methods
Jan 15, 2021
Merged
chore: make FirestoreException factory methods public to allow construction for testing #477
BenWhitehead
merged 1 commit into
googleapis:master
from
BenWhitehead:public-firestore-exception-methods
Jan 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BenWhitehead
commented
Nov 25, 2020
- Expose each factory method at @BetaApi level ensuring no guarantee about api surface
- Expose getStatus() at @BetaApi up from package private @internalapi
product-auto-label
bot
added
the
api: firestore
Issues related to the googleapis/java-firestore API.
label
Nov 25, 2020
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Nov 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
============================================
- Coverage 74.45% 74.43% -0.03%
+ Complexity 1117 1108 -9
============================================
Files 66 66
Lines 5853 5855 +2
Branches 724 726 +2
============================================
Hits 4358 4358
- Misses 1267 1269 +2
Partials 228 228
Continue to review full report at Codecov.
|
schmidt-sebastian
approved these changes
Jan 8, 2021
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreException.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreException.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreException.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreException.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/CollectionReference.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreException.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/UserDataConverter.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/UserDataConverter.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Watch.java
Outdated
Show resolved
Hide resolved
schmidt-sebastian
approved these changes
Jan 12, 2021
…uction for testing * Expose each factory method at @BetaApi level ensuring no guarantee about api surface * Expose getStatus() at @BetaApi up from package private @internalapi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: firestore
Issues related to the googleapis/java-firestore API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.