Merged
Conversation
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: firestore
thebrianchen
force-pushed
the
bc/bulk-backoff
branch
from
ac26884 to
b094577
Compare
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
============================================
+ Coverage 73.85% 73.96% +0.11%
- Complexity 1088 1097 +9
============================================
Files 67 67
Lines 5840 5866 +26
Branches 717 720 +3
============================================
+ Hits 4313 4339 +26
Misses 1302 1302
Partials 225 225
Continue to review full report at Codecov.
|
Contributor
schmidt-sebastian
left a comment
schmidt-sebastian
left a comment
There was a problem hiding this comment.
Some questions about the tests, but implementation LGTM.
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BulkWriterOperation.java
Show resolved
Hide resolved
| @Override | ||
| @Nonnull | ||
| public ScheduledFuture<?> schedule(Runnable command, long delay, TimeUnit unit) { | ||
| int expected = |
Contributor
There was a problem hiding this comment.
This seems unused.
google-cloud-firestore/src/test/java/com/google/cloud/firestore/BulkWriterTest.java
Show resolved
Hide resolved
| @Override | ||
| @Nonnull | ||
| public ScheduledFuture<?> schedule(Runnable command, long delay, TimeUnit unit) { | ||
| if (delay > 0) { |
Contributor
There was a problem hiding this comment.
Same comment as above.
Author
There was a problem hiding this comment.
This test increments retryAttempts so it's ok.
| }); | ||
| bulkWriter.create(doc1, LocalFirestoreHelper.SINGLE_FIELD_MAP); | ||
| bulkWriter.flush(); | ||
| bulkWriter.set(doc1, LocalFirestoreHelper.SINGLE_FIELD_MAP); |
Contributor
There was a problem hiding this comment.
Should this be a different doc?
schmidt-sebastian
approved these changes
Apr 23, 2021
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BulkWriterOperation.java
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/BulkWriterTest.java
Show resolved
Hide resolved
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 26, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.3.0](https://www.github.com/googleapis/java-firestore/compare/v2.2.7...v2.3.0) (2021-04-23) ### Features * add backoff to BulkWriter ([#600](https://www.github.com/googleapis/java-firestore/issues/600)) ([e295aa5](https://www.github.com/googleapis/java-firestore/commit/e295aa5d20007a513e1647575f6935e243825c4d)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v1 ([#607](https://www.github.com/googleapis/java-firestore/issues/607)) ([21e8cde](https://www.github.com/googleapis/java-firestore/commit/21e8cde718b5f2e2f8269d860d0ea3ae810dabdd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combination of 1 and 2 from node.