Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for Composite Filters. #975

Merged
merged 14 commits into from
Jul 11, 2022
Merged

feat: Support for Composite Filters. #975

merged 14 commits into from
Jul 11, 2022

Conversation

ehsannas
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@ehsannas ehsannas requested a review from a team as a code owner June 22, 2022 22:45
@ehsannas ehsannas marked this pull request as draft June 22, 2022 22:45
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Jun 22, 2022
@ehsannas ehsannas changed the title Support for Composite Filters. feat: Support for Composite Filters. Jun 23, 2022
@ehsannas ehsannas added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 23, 2022
Copy link

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas marked this pull request as ready for review July 5, 2022 20:30
@ehsannas ehsannas requested a review from a team as a code owner July 5, 2022 20:30
@ehsannas ehsannas added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2022
@ehsannas ehsannas added owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 11, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2022
@ehsannas ehsannas added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2022
@ehsannas ehsannas merged commit 9d0653a into main Jul 11, 2022
@ehsannas ehsannas deleted the ehsann/or-query-pr-1 branch July 11, 2022 20:49
cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
* Support for Composite Filters.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Minor fixes.

* Remove commented code.

* Better names?

* Update license format.

* Prefer `equals` to `==` for enum comparison.

* We must throw an error if Null or NaN is used in anything other than == or !=.

* Use Nunnull, not NonNull.

* Add tests.

* Remove unrelated comment.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants