This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
test: parametrize GCS Bucket for integration tests #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=========================================
Coverage 75.74% 75.74%
Complexity 127 127
=========================================
Files 12 12
Lines 742 742
Branches 2 2
=========================================
Hits 562 562
Misses 178 178
Partials 2 2Continue to review full report at Codecov.
|
chingor13
changed the title
chingor13
changed the title
chingor13
approved these changes
Jan 29, 2020
google-cloud-language/src/test/java/com/google/cloud/language/it/ITSystemTest.java
Show resolved
Hide resolved
chingor13
approved these changes
Jan 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parametrizing the GCS bucket allows integration tests to pass in a secure environment protected by VPC Service Controls.
The name of the GCS bucket would be made available as an environment variable during test time. If not found, the test can assume that it will access the default cloud-samples-data GCS bucket.