fix: Add cleanup for Trace context #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2020 10:46
Previously we didn't cleanup trace context so it could cause side effects to some tests as a result of added label in trace context tests. To mitigate this, we added a method to cleanup trace context from MDC as well as invoke it before every test
Previously we didn't cleanup trace context so it could cause side effects to some tests as a result of added label in trace context tests. To mitigate this, we added a method to cleanup trace context from MDC as well as invoke it before every test
simonz130
added
type: bug
google-cla
bot
added
the
cla: yes
src/main/java/com/google/cloud/logging/logback/TraceLoggingEventEnhancer.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
============================================
+ Coverage 68.62% 69.03% +0.40%
- Complexity 39 40 +1
============================================
Files 3 3
Lines 153 155 +2
Branches 17 17
============================================
+ Hits 105 107 +2
Misses 33 33
Partials 15 15
Continue to review full report at Codecov.
|
chingor13
requested changes
Dec 10, 2020
chingor13
approved these changes
Dec 10, 2020
simonz130
added
the
automerge
0xSage
approved these changes
Dec 10, 2020
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 14, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [0.119.1](https://www.github.com/googleapis/java-logging-logback/compare/v0.119.0...v0.119.1) (2020-12-14) ### Bug Fixes * Add cleanup for Trace context ([#266](https://www.github.com/googleapis/java-logging-logback/issues/266)) ([af43dfa](https://www.github.com/googleapis/java-logging-logback/commit/af43dfa5a35ba5e2f68de1a7f9c0de838b69c0cf)) ### Dependencies * update dependency com.google.cloud:google-cloud-logging to v2.1.0 ([#268](https://www.github.com/googleapis/java-logging-logback/issues/268)) ([462730e](https://www.github.com/googleapis/java-logging-logback/commit/462730e9008aa084850d24d41ea1778cca8d7ba6)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.16.1 ([469b414](https://www.github.com/googleapis/java-logging-logback/commit/469b4144f5fb37ecf6f99ff5020492614e3d266d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cleanup of trace context before each test execution of tests that set it. This prevents side effects for other tests as a result of random ordering in junit.
Fixes #265 ☕️
Fixes #264 ☕️
Fixes #263 ☕️