Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update synth.py to exclude bot configs #300

Merged
merged 5 commits into from
Jan 21, 2021
Merged

Conversation

simonz130
Copy link

Exclude blunderbuss and codeowners from autosynth.

Fixes #299

simonz130 added 5 commits December 10, 2020 10:46
Previously we didn't cleanup trace context so it could cause side effects to some tests as a result of added label in trace context tests. To mitigate this, we added a method to cleanup trace context from MDC as well as invoke it before every test
Previously we didn't cleanup trace context so it could cause side effects to some tests as a result of added label in trace context tests. To mitigate this, we added a method to cleanup trace context from MDC as well as invoke it before every test
@simonz130 simonz130 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. api: logging Issues related to the googleapis/java-logging-logback API. automerge Merge the pull request once unit tests and other checks pass. labels Jan 21, 2021
@simonz130 simonz130 requested review from a team as code owners January 21, 2021 18:53
@simonz130 simonz130 self-assigned this Jan 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2021
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #300 (6b27e21) into master (e096d74) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #300   +/-   ##
=========================================
  Coverage     69.03%   69.03%           
  Complexity       40       40           
=========================================
  Files             3        3           
  Lines           155      155           
  Branches         17       17           
=========================================
  Hits            107      107           
  Misses           33       33           
  Partials         15       15           
Impacted Files Coverage Δ Complexity Δ
...oud/logging/logback/TraceLoggingEventEnhancer.java 81.81% <ø> (ø) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e096d74...6b27e21. Read the comment docs.

java.common_templates()
java.common_templates(excludes=[
'.gitignore',
'.github/CODEOWNERS',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to override CODEOWNERs unless we need to.

@chingor13 chingor13 changed the title fix: update synth.py to exclude bot configs chore: update synth.py to exclude bot configs Jan 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 820c3b7 into master Jan 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fixSynth.py branch January 21, 2021 22:08
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging-logback API. cla: yes This human has signed the Contributor License Agreement. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blunderbuss and codeowners should not be autogenerated
3 participants