-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Documentation: version number and usage #92
Conversation
Improved documentation: - Synced Javadoc and `README.md`, correcting error about filter in Javadoc - Made example in Javadoc more easy to read and copy
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=========================================
Coverage 68.05% 68.05%
Complexity 35 35
=========================================
Files 2 2
Lines 144 144
Branches 15 15
=========================================
Hits 98 98
Misses 33 33
Partials 13 13
Continue to review full report at Codecov.
|
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
# Conflicts: # README.md
@kolea2 It looks like your CI is using google-java-format built using JDK 11, but the build is started with JDK 8. The build fails because the build JDK does not understand the google-java-format class files. |
Hi @jstuyts, thanks for your patience - I believe this issue should be fixed. Can you try rerunning your presubmit checks? |
I spent 10 minutes trying to find the rerun button or command, but I cannot find it. |
@jstuyts I was able to rerun them! Edit: adding the GitHub workflow instructions: https://help.github.com/en/actions/configuring-and-managing-workflows/managing-a-workflow-run#viewing-your-workflow-history Unfortunately, it looks like it's still failing. @chingor13 can you help take a look here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
fix: Documentation: version number and usage
Updated version number to latest release.
Improved documentation:
README.md
, correcting error about filter in JavadocMade 2 fields final to prevent editor/compiler warning.
Fixes #91