Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace Date with LocalDateTime #1012

Merged
merged 2 commits into from
Aug 18, 2022
Merged

fix: Replace Date with LocalDateTime #1012

merged 2 commits into from
Aug 18, 2022

Conversation

bpcreech
Copy link
Contributor

Fixes #1011

@bpcreech bpcreech requested review from a team as code owners July 24, 2022 00:09
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the googleapis/java-logging API. labels Jul 24, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jul 24, 2022 •
edited

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@losalex losalex self-assigned this Jul 31, 2022
@losalex losalex changed the title Switch from Date to LocalDateTime fix: Switch from Date to LocalDateTime Aug 10, 2022
losalex
losalex approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left a comment, please let me know if it is not a behavior change

@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@bpcreech
Copy link
Contributor Author

Ah, my bad, had a trivial bug in this, hadn't run the integration tests. (Actually just a bug in the test FWIW.) Was trying to get a datetime format out of a LocalDate; needs a LocalDateTime.

It's fixed now.

@losalex losalex changed the title fix: Switch from Date to LocalDateTime fix: switch from Date to LocalDateTime Aug 18, 2022
@losalex losalex changed the title fix: switch from Date to LocalDateTime fix: Replace Date with LocalDateTime Aug 18, 2022
@losalex losalex added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@losalex losalex merged commit 765dd89 into googleapis:main Aug 18, 2022
@release-please release-please bot mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losalex losalex losalex approved these changes

Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/java-logging API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let's use java.time.LocalDateTime instead of java.util.Date
3 participants
@bpcreech @losalex @yoshi-kokoro