samples: limit list log in samples #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
chingor13
commented
Sep 2, 2020
| @@ -35,7 +35,8 @@ public static void main(String... args) throws Exception { | |||
|
|
|||
| try (Logging logging = options.getService()) { | |||
|
|
|||
| String logFilter = "logName=projects/" + options.getProjectId() + "/logs/" + logName; | |||
| String logFilter = "logName=projects/" + options.getProjectId() + "/logs/" + logName + | |||
| " AND timestamp>=\"2020-09-01T00:00:00.000Z\""; | |||
There was a problem hiding this comment.
Note that the code to generate this timestamp string is a bit verbose, so I avoided it for this simple sample. The hard coded date should be good enough to keep the query quick enough and signal to the developer that they should include a timestamp in the query
product-auto-label
bot
added
the
api: logging
lesv
approved these changes
Sep 8, 2020
chingor13
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=========================================
Coverage 75.37% 75.37%
Complexity 593 593
=========================================
Files 42 42
Lines 3712 3712
Branches 259 259
=========================================
Hits 2798 2798
Misses 760 760
Partials 154 154 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
logging_list_log_entriessample to limit logs fetched by timestamp. Querying over the entire log history can take minutes.