Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release 2.1.1-SNAPSHOT #363

Merged
merged 1 commit into from
Dec 14, 2020
Merged

chore: release 2.1.1-SNAPSHOT #363

merged 1 commit into from
Dec 14, 2020

Conversation

release-please[bot]
Copy link
Contributor

馃 I have created a release *beep* *boop*

Updating meta-information for bleeding-edge SNAPSHOT release.

This PR was generated with Release Please.

@release-please release-please bot requested review from a team as code owners December 11, 2020 00:35
@release-please release-please bot added the type: process A process-related concern. May include testing, release, or the like. label Dec 11, 2020
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Dec 11, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2020
yoshi-approver
yoshi-approver approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@yoshi-approver yoshi-approver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamped release!

@yoshi-approver yoshi-approver added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 11, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2020
chingor13
chingor13 requested changes Dec 11, 2020
View reviewed changes
samples/install-without-bom/pom.xml
@@ -29,7 +29,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-logging</artifactId>
<version>2.1.0</version>
<version>2.1.1-SNAPSHOT</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be getting version bumped here.

@chingor13 chingor13 mentioned this pull request Dec 11, 2020
Merged
@codecov
Copy link

codecov bot commented Dec 11, 2020 •
edited

Codecov Report

Merging #363 (796a4f0) into master (d11d93a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #363   +/-   ##
=========================================
  Coverage     76.67%   76.67%           
  Complexity      680      680           
=========================================
  Files            44       44           
  Lines          4249     4249           
  Branches        287      287           
=========================================
  Hits           3258     3258           
  Misses          826      826           
  Partials        165      165

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d11d93a...796a4f0. Read the comment docs.

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 11, 2020
@chingor13 chingor13 merged commit 0d7c74b into master Dec 14, 2020
@chingor13 chingor13 deleted the release-v2.1.1-SNAPSHOT branch December 14, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@yoshi-approver yoshi-approver yoshi-approver approved these changes

Assignees
No one assigned
Labels
api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chingor13 @yoshi-approver @yoshi-kokoro