This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Conversation
…g location as custom project, folder, organization or billing account
product-auto-label
bot
added
the
api: logging
google-cla
bot
added
the
cla: yes
minherz
suggested changes
Oct 27, 2021
Contributor
There was a problem hiding this comment.
We recommend to minimize the scope of changes in order to speed up and simplify the reviewing process. It reduces a cognitive load of the reviewer and helps avoiding mistakes.
[edited] For the next time, please split changes into multiple PRs. In this PR we shall finish reviewing the changes related to the write interface and then will do modifications to LoggingHandler and LoggingHandlerTest, since the latter changes are not directly related to the PR's description and the linked issue(s).
google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
minherz
suggested changes
Oct 31, 2021
Contributor
minherz
left a comment
minherz
left a comment
There was a problem hiding this comment.
Please, have a look into comments for changes in the LoggingImplTest.java
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingTest.java
Show resolved
Hide resolved
minherz
approved these changes
Nov 2, 2021
Contributor
minherz
left a comment
minherz
left a comment
There was a problem hiding this comment.
LGTM. Feel free to ignore or apply the comment about request variable name.
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposed an ability to set logs destination in WriteOption and added an ability to customize log destination in LoggingHandler
Fixes #684 ☕️