Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow opt-out auto-population of the log entry metadata on write() #798

Merged
merged 3 commits into from Dec 16, 2021

Conversation

minherz
Copy link
Contributor

@minherz minherz commented Dec 15, 2021

Provides opt-out configuration on the Logging instance and Logging.write() API levels to opt-out automatically populate empty metadata fields of the log entries being submitted for writing.

Fixes #689

allow to opt-out auto populate log entry metadata on write in the write()
API and Logging instance levels.
@minherz minherz requested review from a team as code owners December 15, 2021 12:24
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Dec 15, 2021
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test need to be added

Test WriteOption to out-out  auto populating metadata.
Test LoggingOption to out-out  auto populating metadata.
Test default LoggingOption for auto populating metadata.
Refactor LoggingOptions tests.
Refactor LoggingOptions auto populate metadata getter method.
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minherz minherz merged commit 97c36a6 into minher/structured_logging Dec 16, 2021
@minherz minherz deleted the minherz/689 branch December 16, 2021 17:54
minherz added a commit that referenced this pull request Dec 30, 2021
…e() (#798)

Allows to opt-out auto populate log entry metadata on write in the write() API and Logging instance levels.
Tests WriteOption to out-out  auto populating metadata.
Tests LoggingOption to out-out  auto populating metadata.
Tests default LoggingOption for auto populating metadata.
Refactors LoggingOptions tests.
Refactors LoggingOptions auto populate metadata getter method.
Fixes cast compilation warning.
minherz added a commit that referenced this pull request Jan 4, 2022
…e() (#798)

Allows to opt-out auto populate log entry metadata on write in the write() API and Logging instance levels.
Tests WriteOption to out-out  auto populating metadata.
Tests LoggingOption to out-out  auto populating metadata.
Tests default LoggingOption for auto populating metadata.
Refactors LoggingOptions tests.
Refactors LoggingOptions auto populate metadata getter method.
Fixes cast compilation warning.
minherz added a commit that referenced this pull request Jan 5, 2022
…e() (#798)

Allows to opt-out auto populate log entry metadata on write in the write() API and Logging instance levels.
Tests WriteOption to out-out  auto populating metadata.
Tests LoggingOption to out-out  auto populating metadata.
Tests default LoggingOption for auto populating metadata.
Refactors LoggingOptions tests.
Refactors LoggingOptions auto populate metadata getter method.
Fixes cast compilation warning.
minherz added a commit that referenced this pull request Jan 7, 2022
…ogs redirection to stdout in JUL handler (#808)

Aggregates the following work:
- #821
- #812
- #807
- #803
- #798

Fixes #689, #691, #799 and #800

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants