Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update README #814

Merged

Conversation

minherz
Copy link
Contributor

@minherz minherz commented Jan 2, 2022

add short description about automatic metadata population and redirection of JUL logs to stdout to README.

@minherz minherz requested review from a team as code owners January 2, 2022 14:39
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 2, 2022
@minherz minherz requested a review from losalex January 2, 2022 14:39
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Jan 2, 2022
@minherz minherz self-assigned this Jan 2, 2022
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update instructions about manual context usage with samples about configuring inherited context.

.readme-partials.yaml Outdated Show resolved Hide resolved
.readme-partials.yaml Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 3, 2022
@minherz minherz requested a review from losalex January 4, 2022 07:50
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some extra comments - please take a look

add short description about automatic metadata population
and redirection of JUL logs to stdout to README.
change the order of options to manage the context.
describe configuration to enable inheriting context in child scopes (threads).
@minherz minherz force-pushed the minherz/structured_logging_readme branch from f9896ef to 1f6f281 Compare January 5, 2022 08:36
reverse the use of 'appendComma' flag
rename populateMetadata? flags to make the logic clear
@minherz minherz merged commit c8b0ee8 into minherz/structured_logging Jan 5, 2022
@minherz minherz deleted the minherz/structured_logging_readme branch January 5, 2022 11:57
@minherz minherz restored the minherz/structured_logging_readme branch January 6, 2022 11:27
minherz added a commit that referenced this pull request Jan 6, 2022
minherz added a commit that referenced this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants