Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): set gson via java-shared-deps #878

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Feb 22, 2022

Gson dependency version should be set by the java-shared-dependencies BOM, so that the artifacts listed in the google-cloud-bom have the same set of the dependencies.

This should fix one of the problems in googleapis/java-cloud-bom#3593 (comment).

CC: @Neenu1995

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

Gson dependency version should be set by the java-shared-
dependencies BOM, so that the artifacts listed in the google-
cloud-bom have the same set of the dependencies.
@suztomo suztomo requested review from a team as code owners February 22, 2022 19:22
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/java-logging API. labels Feb 22, 2022
@Neenu1995 Neenu1995 assigned minherz and unassigned simonz130 Feb 22, 2022
@suztomo
Copy link
Member Author

suztomo commented Feb 22, 2022

"Environment - Functions" failed but it's not a required check.

+ /tmpfs/src/github/java-logging/env-tests-logging/envctl/envctl java functions destroy
Error: not a valid environment: functions

Select a supported GCP environment.

@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2022
@suztomo suztomo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 24, 2022
@suztomo
Copy link
Member Author

suztomo commented Feb 24, 2022

Integration test failed: https://source.cloud.google.com/results/invocations/bdbdf260-4bd8-4eb3-bde5-e79aba043a7e/targets/github%2Fjava-logging%2Fgoogle-cloud-logging%2Ftarget%2Ffailsafe-reports%2Fintegration%2Fcom.google.cloud.logging.it.ITTailLogsTest/tests

com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Read requests' and limit 'Read requests per minute' of service 'logging.googleapis.com' for consumer 'project_number:1016721519174'.

@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2022
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 25, 2022
@suztomo suztomo merged commit 5c97fea into googleapis:main Feb 25, 2022
@suztomo suztomo deleted the gson_definition branch February 25, 2022 18:39
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 28, 2022
🤖 I have created a release *beep* *boop*
---


## [3.7.0](v3.6.4...v3.7.0) (2022-02-28)


### Features

* KMS configuration in settings ([#877](#877)) ([27c199b](27c199b))
* Update Logging API with latest changes ([27c199b](27c199b))


### Bug Fixes

* **deps:** set gson via java-shared-deps ([#878](#878)) ([5c97fea](5c97fea))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants