Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

test: refresh VPCSC tests #52

Merged
merged 4 commits into from Jan 29, 2020
Merged

Conversation

steinwaywhw
Copy link
Contributor

Refresh VPCSC tests to cover AgentTranslationService/CollectdTimeSeries endpoint.

Refresh VPCSC tests to cover AgentTranslationService/CollectdTimeSeries endpoint.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2020
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #52   +/-   ##
=========================================
  Coverage     73.13%   73.13%           
  Complexity      419      419           
=========================================
  Files            36       36           
  Lines          3384     3384           
  Branches         47       47           
=========================================
  Hits           2475     2475           
  Misses          849      849           
  Partials         60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236e957...24726a6. Read the comment docs.

@steinwaywhw steinwaywhw changed the title Refresh VPCSC tests. test: Refresh VPCSC tests. Jan 28, 2020
The stream is Java 8 specific, which breaks Java 7 tests. Remove its usage.
@chingor13 chingor13 changed the title test: Refresh VPCSC tests. test: refresh VPCSC tests Jan 28, 2020
@steinwaywhw
Copy link
Contributor Author

@chingor13 Hi Jeff, the dependency failure is due to a dependency on come.google.auth:google-auth-library-oauth2-http. Could you advise on how to add this dependency?

@chingor13
Copy link
Contributor

For the dependencies test failure, you'll want to add:

<dependency>
  <groupId>com.google.auth</groupId>
  <artifactId>google-auth-library-oauth2-http</artifactId>
  <version>0.20.0</version>
  <scope>test</scope>
</dependency>

to the <dependencies> section of google-cloud-monitoring/pom.xml

Add a test dependency on com.google.auth:google-auth-library-oauth2-http
@steinwaywhw
Copy link
Contributor Author

Thanks!

@chingor13
Copy link
Contributor

Sorry, 0.20.0 is having dependency issues (until we can update guava), 0.19.0 fixes it

@chingor13 chingor13 merged commit 538ea1d into googleapis:master Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
3 participants