Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

fix: add region tags for GCP documentation that references the README. #59

Merged
merged 1 commit into from Feb 6, 2020

Conversation

willgoldby
Copy link
Contributor

fix: add region tags for GCP documentation that references the README

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 5, 2020
@willgoldby
Copy link
Contributor Author

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 5, 2020
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2020
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage     73.13%   73.13%           
  Complexity      419      419           
=========================================
  Files            36       36           
  Lines          3384     3384           
  Branches         47       47           
=========================================
  Hits           2475     2475           
  Misses          849      849           
  Partials         60       60
Impacted Files Coverage Δ Complexity Δ
.../cloud/monitoring/v3/UptimeCheckServiceClient.java 54.45% <0%> (ø) 23% <0%> (ø) ⬇️
.../cloud/monitoring/v3/AlertPolicyServiceClient.java 63.21% <0%> (ø) 23% <0%> (ø) ⬇️
...monitoring/v3/stub/GrpcUptimeCheckServiceStub.java 92.1% <0%> (ø) 12% <0%> (ø) ⬇️
...monitoring/v3/stub/GrpcAlertPolicyServiceStub.java 92.36% <0%> (ø) 12% <0%> (ø) ⬇️
...cloud/monitoring/v3/stub/GrpcGroupServiceStub.java 93.28% <0%> (ø) 13% <0%> (ø) ⬇️
...toring/v3/stub/UptimeCheckServiceStubSettings.java 75% <0%> (ø) 16% <0%> (ø) ⬇️
...toring/v3/stub/AlertPolicyServiceStubSettings.java 80.74% <0%> (ø) 15% <0%> (ø) ⬇️
...loud/monitoring/v3/stub/GrpcMetricServiceStub.java 94.63% <0%> (ø) 15% <0%> (ø) ⬇️
...ring/v3/stub/GrpcServiceMonitoringServiceStub.java 95.43% <0%> (ø) 17% <0%> (ø) ⬇️
...d/monitoring/v3/stub/GroupServiceStubSettings.java 79.87% <0%> (ø) 16% <0%> (ø) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6405d70...3789c5d. Read the comment docs.

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving/merging to unblock cloudsite. We actually want these in a separate snippet, which I'll add separately.

@chingor13 chingor13 merged commit 1b1c5db into googleapis:master Feb 6, 2020
@willgoldby
Copy link
Contributor Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
4 participants