Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flow control support to publisher #119

Merged
merged 2 commits into from Mar 25, 2020

Conversation

kamalaboulhosn
Copy link
Contributor

@kamalaboulhosn kamalaboulhosn commented Mar 24, 2020

Fixes #25

@googlebot googlebot added the cla: yes label Mar 24, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 24, 2020

Codecov Report

Merging #119 into master will increase coverage by 0.19%.
The diff coverage is 84.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #119      +/-   ##
============================================
+ Coverage     79.36%   79.56%   +0.19%     
- Complexity      305      308       +3     
============================================
  Files            21       21              
  Lines          2603     2701      +98     
  Branches        115      133      +18     
============================================
+ Hits           2066     2149      +83     
- Misses          467      477      +10     
- Partials         70       75       +5     
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 87.96% <84.53%> (-1.14%) 46.00 <5.00> (+3.00) ⬇️
...gle/cloud/pubsub/v1/SequentialExecutorService.java 91.01% <100.00%> (+0.20%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6783ec...6bb47bc. Read the comment docs.

Copy link
Contributor

@hannahrogers-google hannahrogers-google left a comment

LGTM. A couple of comments, nothing major

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants