Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix ordered publish failure test by forcing scheduled work to be done #2025

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

test: Fix ordered publish failure test by forcing scheduled work to be done #2025

wants to merge 6 commits into from
+8 −11

Conversation

michaelpri10
Copy link
Contributor

@michaelpri10 michaelpri10 commented May 13, 2024 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1861 ☕️

If you write sample code, please follow the samples format.

@michaelpri10 michaelpri10 requested a review from a team as a code owner May 13, 2024 20:01
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/java-pubsub API. labels May 13, 2024
@michaelpri10 michaelpri10 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 14, 2024
@michaelpri10 michaelpri10 requested a review from a team as a code owner May 14, 2024 07:08
@michaelpri10 michaelpri10 removed the request for review from kamalaboulhosn May 14, 2024 18:42
@michaelpri10
Copy link
Contributor Author

Seeing the PublisherImplTest still timing out, so doing some more investigation.

@michaelpri10 michaelpri10 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 20, 2024
@michaelpri10
Copy link
Contributor Author

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamalaboulhosn kamalaboulhosn Awaiting requested review from kamalaboulhosn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PublisherImplTest is timing out
1 participant
@michaelpri10